RFR: 8280993: [XWayland] Popup is not closed on click outside of area controlled by XWayland [v2]

[Alexander Zvegintsev]

On Thu, 18 May 2023 22:32:13 GMT, Phil Race <prr at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   undo documentation changes
>
> src/java.desktop/share/classes/javax/swing/JPopupMenu.java line 767:
> 
>> 765:     }
>> 766: 
>> 767:     // We rely on the X11 input grab mechanism, but for the Wayland session
> 
> Whilst we need to do this, having all this code discussing Wayland here in JPopupMenu is really the wrong place.
> This needs to be re-done in a way that is about the specific problem which is something like
> SunToolkit.clickOutsideWillDismissPopup() 
> and the word "Wayland" shouldn't appear anywhere here.
> 
> IIUC this fix is needed so that a number of tests that fail now because of this problem will be able to pass, so it would be good to get it in soon so I can get a clearer picture of what remaining test issues we have.

Sure, moved to toolkit.

> IIUC this fix is needed so that a number of tests that fail now because of this problem will be able to pass, so it would be good to get it in soon so I can get a clearer picture of what remaining test issues we have.

This only affects manual tests, as automatic tests use the XTest API, which works correctly with X11 Input Grab.

Besides, this is a real use case that can be annoying. This change doesn't fix the problem completely (we still can't hide the menu by clicking on the title bar of our own window or on non-focusable windows such as the desktop), but it definitely makes the user experience better.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13830#discussion_r1199126453