RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v7]

[Alexey Ivanov]

On Fri, 19 May 2023 18:02:33 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> The updated test covers all the existing cases as well as a few more cases for which I raised my concerns above.

To be more specific, it produces the following output:


margin-top=100%  is not equal to margin-top=100%
font-size=42px  is equal to font-size=22px
font-size=42px  is equal to font-size=42pt
font-size=42em  is equal to font-size=42ex
font-size=100%  is equal to font-size=200%
margin-top=42px  is equal to margin-top=42pt
java.lang.RuntimeException: 6 failure(s) detected: margin-top=100%  is not equal to margin-top=100%
        at CSSAttributeEqualityBug.main(CSSAttributeEqualityBug.java:105)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccess
or.java:103)
        at java.base/java.lang.reflect.Method.invoke(Method.java:578)
        at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:125)
        at java.base/java.lang.Thread.run(Thread.java:1630)


The new test does not provide direct references to `CSS.CssValue` subclasses, yet it's somewhat easy to infer. Comments in the arrays could refer to the class, for example `margin-top` uses `CSS.LengthValue`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13405#issuecomment-1555052119