RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v8]

Alexey Ivanov aivanov at openjdk.org
Tue May 23 15:13:30 UTC 2023


On Tue, 23 May 2023 08:32:53 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> The current PR passes regression test along with jtreg/jck tests  
> The suggested changes above does not pass the regression test

I haven't tested the code above, I wrote it off the top of my head right here. Anyway passing tests are a good baseline.

Yet I am strongly against parsing the CSS string in `equals`, it has *already* been parsed. I'll get to it later.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13405#discussion_r1202100159



More information about the client-libs-dev mailing list