RFR: 8306812: Open source several AWT Miscellaneous tests [v4]

Sergey Bylokhov serb at openjdk.org
Wed May 24 03:03:59 UTC 2023


On Fri, 12 May 2023 05:32:14 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Open source few AWT Miscellaneous ( Panel, Popup, robot and scrollbar) tests.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated based on review comments

test/jdk/java/awt/PopupMenu/PopupMenuStayOpen.java line 30:

> 28:   @summary Checks that popup menu stay open after a triggering click.
> 29:   @key headful
> 30:   @run main/othervm -Dsun.java2d.uiScale=1 PopupMenuStayOpen

Why do you need to set uiscale=1 in this test?

test/jdk/java/awt/Robot/RobotMoveMultiscreen.java line 82:

> 80:             robot.waitForIdle();
> 81: 
> 82:             if (testCondition == false) {

testCondition is set on EDT and used on the main thread here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13828#discussion_r1203342226
PR Review Comment: https://git.openjdk.org/jdk/pull/13828#discussion_r1203342735



More information about the client-libs-dev mailing list