RFR: 8306812: Open source several AWT Miscellaneous tests [v4]

Sergey Bylokhov serb at openjdk.org
Wed May 24 03:04:01 UTC 2023


On Fri, 5 May 2023 17:57:33 GMT, Phil Race <prr at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated based on review comments
>
> test/jdk/java/awt/Scrollbar/ScrollbarKeyControlTest.java line 61:
> 
>> 59:             System.out.println("This test is for XAWT only.");
>> 60:             return;
>> 61:         }
> 
> This is largely pointless since you have requires os==linux.
> Perhaps its from when we had MToolkit.
> If you keep it, then I'd make it just check the "os.name" and not the toolkit

Does this test work on mac or windows? if not any reason why?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13828#discussion_r1203343990



More information about the client-libs-dev mailing list