RFR: 8306137: Open source several AWT ScrollPane related tests [v13]

Tejesh R tr at openjdk.org
Wed May 24 03:43:11 UTC 2023


On Wed, 24 May 2023 02:56:30 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated based on review comments
>
> test/jdk/java/awt/ScrollPane/ScrollPositionIntact.java line 91:
> 
>> 89:                 int i = (int) (sp.getScrollPosition().getX());
>> 90:                 if (i == 0) {
>> 91:                     // actual position MAY be not equal to X_POS; still, it must be > 0.
> 
> If the valid value is "> 0" only, then we should throw an exception if the value is "<=0"

Yes, right. Updated the test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13621#discussion_r1203369592



More information about the client-libs-dev mailing list