RFR: 8294535 : Add screen capture functionality to PassFailJFrame

Harshitha Onkar honkar at openjdk.org
Fri May 26 18:58:57 UTC 2023


On Thu, 25 May 2023 11:24:42 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> There could be multiple files. In fact, I question the need for a modal dialog confirming that the operation completed successfully. If an error occurs, a modal dialog is a good way of notifying. If no error occurs, the message is somewhat redundant.
> 
> If the displayed message isn't modal, like a tooltip or a notification which disappears automatically after a certain time, it could be better appreciated. But it's harder to implement.
> 
> What could be helpful though is an option to open the current directory in File Explorer, Finder… to allow viewing the collected screenshots. It's more helpful than displaying file names, isn't it?

We can keep it as it is now or show message dialog only on failure, both sound okay. Maybe the File explorer and notification can be explored later.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14094#issuecomment-1564799601



More information about the client-libs-dev mailing list