RFR: 8307105: JFileChooser InvalidPathException when selecting some system folders on Windows [v7]

[Tejesh R]

On Tue, 30 May 2023 09:10:03 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Tejesh R has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>> 
>>  - Updated new fix
>>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into branch_8307105
>>  - White space fix
>>  - Alternate Fix
>>  - Updated based on review comments
>>  - Updated based on review comments
>>  - Updated based on review comments
>>  - Fix + Manual Test
>
> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line 862:
> 
>> 860:     //Checks only if it's .lnk shortcut link. Other two links
>> 861:     //namely Symbolic and Junctions returns false, so that the
>> 862:     //absolute path can be resolved.
> 
> Should it be included inside the javadoc as an `@implNote`? The class isn't public so we can change it, and it is more helpful because it's shown right away without opening source code for the method.

Adding as `@implNote` would be better.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13998#discussion_r1211135049