RFR: 8319268: Build failure with GCC8.3.1 after 8313643 [v2]

[Erik Joelsson]

On Thu, 2 Nov 2023 07:14:14 GMT, null <duke at openjdk.org> wrote:

>> Build failure with GCC8.3.1
>> 
>> === Output from failing command(s) repeated here ===
>> * For target support_native_java.desktop_libfontmanager_hb-ot-layout.o:
>> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc: In function 'hb_bool_t hb_ot_layout_get_font_extents(hb_font_t*, hb_direction_t, hb_tag_t, hb_tag_t, hb_font_extents_t*)':
>> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc:2136:26: error: 'max' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>>        extents->ascender = max;
>>        ~~~~~~~~~~~~~~~~~~~^~~~~
>> /data/codes/bobjdk/src/java.desktop/share/native/libharfbuzz/hb-ot-layout.cc:2137:26: error: 'min' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>>        extents->descender = min;
>>        ~~~~~~~~~~~~~~~~~~~^~~~~
>> At global scope:
>> cc1plus: error: unrecognized command line option '-Wno-dangling-reference' [-Werror]
>> cc1plus: all warnings being treated as errors
>> 
>> * All command lines available in /data/codes/bobjdk/build/linux-x86_64-server-release/make-support/failure-logs.
>> === End of repeated output ===
>> 
>> No indication of failed target found.
>> HELP: Try searching the build log for '] Error'.
>> HELP: Run 'make doctor' to diagnose build problems.
>> 
>> make[1]: *** [main] Error 1
>> make: *** [images] Error 2
>
> null has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add comments

make/modules/java.desktop/lib/Awt2dLibraries.gmk line 508:

> 506:    # expansion-to-defined required for GCC 9 builds. Not required for GCC 10+.
> 507:    # maybe-uninitialized required for GCC 8 builds. Not required for GCC 9+.
> 508:    HARFBUZZ_DISABLED_WARNINGS_CXX_gcc := class-memaccess noexcept-type expansion-to-defined dangling-reference maybe-uninitialized

This line is getting very long, could you break it up?
Suggestion:

   HARFBUZZ_DISABLED_WARNINGS_CXX_gcc := class-memaccess noexcept-type \
       expansion-to-defined dangling-reference maybe-uninitialized

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16468#discussion_r1380095140