RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v14]

[Julian Waters]

On Thu, 2 Nov 2023 21:10:45 GMT, Phil Race <prr at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Changes awt_Frame.cpp
>
> src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 61:
> 
>> 59: 
>> 60: jfieldID AwtPrintDialog::pageID;
>> 61: 
> 
> where and why did this come from ?

This came from below, all I did was move it up and out of the extern "C" block. This cannot be inside extern "C" because it is a static class member and has permanent C++ name mangling

> src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 533:
> 
>> 531: 
>> 532:     {
>> 533:         HWND parentID = AwtPrintControl::getParentID(env, self);
> 
> diff is making this really hard to compare line by line
> So here you've just put the code in { .. } and indented ? 
> What is the warning that motivates this ?
> I don't see where you describe it.

I haven't gotten around to converting this to the new approach of splitting declaration and assignment, but yes, that is all I've done. I've described the problem here above

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1381112565
PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1381113001