RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v5]
Phil Race
prr at openjdk.org
Fri Nov 3 17:20:09 UTC 2023
On Fri, 3 Nov 2023 04:58:24 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>>
>> "Sets the minimum size of this component to a constant value. Subsequent calls to getMinimumSize will always return this value..."
>>
>> However, JScrollBar overrides getMinimumSize() and breaks this contract - it always returns a minimum size derived from the preferred size even if you have previously called setMinimumSize()
>>
>> Fix is made to check if mnimumSize is set and if so, honour it..
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove unneeded methods
Wait, when did we ever discuss setEnabled() ? I know the comment refers to 3 methods and we observed that but all the discussion and testing has been about the size ones.
Take any changes to that out of this PR.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15325#issuecomment-1792836975
More information about the client-libs-dev
mailing list