RFR: 8074211: javax.sound.midi: Error with send System Exclusive messages of different length [v3]

[Sergey Bylokhov]

On Mon, 6 Nov 2023 21:10:55 GMT, Phil Race <prr at openjdk.org> wrote:

>> Alec Su has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Code cleanup
>
> test/jdk/javax/sound/midi/Devices/OutputBuffer.java line 33:
> 
>> 31:  *          is sent again with the next sysex message
>> 32:  * @comment This test does not fail when the bug occurs. It requires manual
>> 33:  *          monitoring of the output.
> 
> The fix seems reasonable. but this test comment is odd. I'm not sure I understand what you can mean by manual monitoring of the output. The test doesn't seem useful unless it can detect failure.

The test is useful since that is the only test that touches the code path when the buffer for the midi message is reused and the bug can be reproduced. at least it doesn't crash.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16399#discussion_r1384051387