RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v6]

Prasanta Sadhukhan psadhukhan at openjdk.org
Tue Nov 7 03:31:31 UTC 2023


On Mon, 6 Nov 2023 06:22:33 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>> 
>> "Sets the minimum size of this component to a constant value. Subsequent calls to getMinimumSize will always return this value..."
>> 
>> However, JScrollBar overrides getMinimumSize() and breaks this contract - it always returns a minimum size derived from the preferred size even if you have previously called setMinimumSize()
>> 
>> Fix is made to check if mnimumSize is set and if so, honour it..
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reinstate setEnabled

Can you please attach your testcode in JBS?
I tried with the testcases JScrollBarMinLayout.java and JScrollBarMaxLauout.java resizing the frame and I dont see any difference in layout behaviour of the scrollbars with and without these getXXX methods.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15325#issuecomment-1797642668


More information about the client-libs-dev mailing list