RFR: 8074211: javax.sound.midi: Error with send System Exclusive messages of different length [v3]

Alec Su duke at openjdk.org
Tue Nov 7 16:22:04 UTC 2023


On Mon, 6 Nov 2023 20:53:53 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Alec Su has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Code cleanup
>
> test/jdk/javax/sound/midi/Devices/OutputBuffer.java line 34:
> 
>> 32:  * @comment This test does not fail when the bug occurs. It requires manual
>> 33:  *          monitoring of the output.
>> 34:  * @requires os.family == "windows"
> 
> The test does not use any Windows-specific API, this check can be removed so the code will be covered on all platforms.

OK, I removed the check.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16399#discussion_r1385192529


More information about the client-libs-dev mailing list