RFR: 8319598: SMFParser misinterprets interrupted running status
Jan Trukenmüller
duke at openjdk.org
Tue Nov 7 19:37:03 UTC 2023
The MIDI file parser misinterprets events without status byte when they appear directly after a Meta of SysEx event.
For my bugfix I had to decide between two possible solutions:
- Strict solution: Throw an InvalidMidiDataException
- Tolerant solution: Use the status of the last channel event as running status
I used the tolerant solution.
I will send an email to the list client-libs-dev with my reasons.
-------------
Commit messages:
- 8319598: Fixed incorrect interpretation of interrupted running status in SMFParser
Changes: https://git.openjdk.org/jdk/pull/16546/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16546&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8319598
Stats: 121 lines in 2 files changed: 118 ins; 0 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/16546.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/16546/head:pull/16546
PR: https://git.openjdk.org/jdk/pull/16546
More information about the client-libs-dev
mailing list