RFR: 5108458: JTable does not properly layout its content [v3]

Tejesh R tr at openjdk.org
Wed Nov 8 10:57:58 UTC 2023


On Wed, 8 Nov 2023 10:08:02 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review fix
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTableUI.java line 2106:
> 
>> 2104:                     columnWidth = aColumn.getWidth();
>> 2105:                     cellRect.width = columnWidth - columnMargin;
>> 2106:                     paintCell(g, cellRect, row, cMax);
> 
> Is this code snippet required? It was not needed for LTR..
> Guess we do the check in l2113 where we do paintCell for the same..

Yeah, it maybe to ensure minimum one column is painted/visible during Table drag i.e., meaning when table is shrink to min. But not exactly sure why one column is painted first and then the remaining.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16374#discussion_r1386436906


More information about the client-libs-dev mailing list