Integrated: 6928542: Chinese characters in RTF are not decoded

Ichiroh Takiguchi itakiguchi at openjdk.org
Thu Nov 9 01:07:16 UTC 2023


On Thu, 20 Apr 2023 05:47:35 GMT, Ichiroh Takiguchi <itakiguchi at openjdk.org> wrote:

> "character set of font" (font charset) table was created by "Rich Text Format Specification 1.9.1"
> https://interoperability.blob.core.windows.net/files/Archive_References/[MSFT-RTF].pdf
> It refers windgi.h
> https://learn.microsoft.com/en-us/windows/win32/api/wingdi/ns-wingdi-textmetrica
> 
> Test files and testcase are in bugid [JDK-6928542](https://bugs.openjdk.org/browse/JDK-6928542)
> 
> Additional change:
> Special character `\line` should `\n`
> 
> Additional information:
> 
> Add 2 hash tables
> - fcharsetToCP: Predefined conversion table, `fcharset` with number control word, from control word to Java charset name, `fcharset0` refers `windows-1252` Java charset name
> - fcharsetTable: Conversion table for each RTF file, `f` control word with number, from integer font numbers to Charset font charsets, In case of `{\f0\fnil\fcharset0 Segoe UI;}`, `0` refers Java Charset `windows-1252`
> 
> When RTF Character Set control word (like `\mac`) is used, unmappable character returns \u0000 and it's not written into RTF text..
> When fcharset control word is used, unmappable character returns \uFFFD (it's the same as replacement character on decoder), \u0000 is used for DBCS lead byte detection.
> If `f` or `par` control word is there and lead byte is remains on byte buffer for decoder, this byte data is as invalid character and write \uFFFD into RTF text.
> 
> If `f` control word is used without `fcharset`, `translationTable` char array is used.
> If `f` control word is used with `fcharset`, predefined Java Charset name is used (if missing, ISO8859_1 is used for fallback).
> 
> **Note:** Following GitHub actions were failed
> linux-cross-compile / build (riscv64), I opened following JBS.
>> [JDK-8314624](https://bugs.openjdk.org/browse/JDK-8314624) GHA: RISC-V cross-build was failed

This pull request has now been integrated.

Changeset: a26f7c03
Author:    Ichiroh Takiguchi <itakiguchi at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a26f7c03c72e4efe6d3219d294294c554aebc631
Stats:     286 lines in 3 files changed: 282 ins; 0 del; 4 mod

6928542: Chinese characters in RTF are not decoded

Reviewed-by: prr, psadhukhan

-------------

PR: https://git.openjdk.org/jdk/pull/13553


More information about the client-libs-dev mailing list