RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v10]
Alexey Ivanov
aivanov at openjdk.org
Thu Nov 9 19:19:09 UTC 2023
On Thu, 9 Nov 2023 18:42:24 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> The issue exist only for non-editable combobox and the root cause is accessible object is not created due to incorrect index returned from component class which results in no a11y API invoked.
>>
>> Proposed solution is to return the correct accessible child from getAccessibleChild method which is AquaComboBoxButton (arrowButton) instance and that results in invoking the a11y APIs to return the current selected item in combobox.
>>
>> Further when the application comes up first time the accessible name is not set for current displayed item in JCombobox that is handled in AquaComboBoxButton which will take care for the current selected item as well as if user modifies the selection by drop-down list.
>>
>> CI link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> Extend Accessible class to return accessible name
test/jdk/javax/accessibility/JComboBox/TestJComboBoxScreenMagnifier.java line 33:
> 31: * screen magnifier a11y tool
> 32: * @run main/manual TestJComboBoxScreenMagnifier
> 33: */
Could you please move the jtreg tags below the imports, above the class declaration? This way, they're easier to see in an IDE. Not required though, some people still prefer the tags above the imports.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1388479097
More information about the client-libs-dev
mailing list