RFR: 8210807: Printing a JTable with a JScrollPane prints table without rows populated [v3]

[Tejesh R]

On Wed, 8 Nov 2023 13:33:26 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review fix
>
> src/java.desktop/share/classes/javax/swing/JViewport.java line 607:
> 
>> 605: 
>> 606:     private Graphics getBackingStoreGraphics(Graphics g) {
>> 607:         if (g instanceof SunGraphics2D) {
> 
> One thing is the change is not obvious as to why it is being done.
> I think we can make the fix more telling by utilizing isPrinting check to make it prominent that the code path is for printing
> Suggestion:
> 
>        if (!SwingUtilities2.isPrinting(g)) {
> 
> Can you see if it works? And yes, you have to make the method public..

Yes, it works, can't use `SwingUtilities2.isPrinting(g)` but can check for `PrintGraphics` instance which is done in `SwingUtilities2.isPrinting(g)` .. Thank you for the input...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16552#discussion_r1388900035