RFR: 8210807: Printing a JTable with a JScrollPane prints table without rows populated [v6]

[Prasanta Sadhukhan]

On Fri, 10 Nov 2023 07:41:22 GMT, Tejesh R <tr at openjdk.org> wrote:

>> `BackingStore` uses its own Graphics to Paint the Image. This is fine when we want to paint it on a Window/Frame, but fails to print. Since `WPathGraphics` is used for Printing, backing store fails to print it and backing store uses newly created `SunGraphics2D` always. The proposed fix is to ignore `backingstore` graphics if passed on Graphics is different from `SunGraphics2D` which ensures the Image is painted on Window and also printed when required. 
>> The fix is tested in CI and doesn't cause any regression. The test is verified manually.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review fix

test/jdk/javax/swing/JTable/JTableScrollPrintTest.java line 100:

> 98:             model.addColumn("Column 4");
> 99: 
> 100:             for (int row=1;row<=5;row++)

Need a {
and space needed between operator and number

test/jdk/javax/swing/JTable/JTableScrollPrintTest.java line 168:

> 166:                 double yscale = imageableY/panelY;
> 167:                 double optimalScale;
> 168:                 if (xscale < yscale)

if -else need a {

test/jdk/javax/swing/JTable/JTableScrollPrintTest.java line 173:

> 171:                     optimalScale = yscale;
> 172: 
> 173:                 if (optimalScale > 1)

here too

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16552#discussion_r1389036249
PR Review Comment: https://git.openjdk.org/jdk/pull/16552#discussion_r1389036787
PR Review Comment: https://git.openjdk.org/jdk/pull/16552#discussion_r1389036982