RFR: 8283214: [macos] Screen magnifier does not show the magnified text for JcomboBox [v8]

Abhishek Kumar abhiscxk at openjdk.org
Fri Nov 10 18:23:15 UTC 2023


On Thu, 12 Oct 2023 15:33:49 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>> 
>>  - AccessibleName set in Listener
>>  - Master
>>  - Revert BasicComboBoxUI fix and update review comment
>>  - bugid removed in comments
>>  - Add condition to check JLabel instance
>>  - set accessiblename to displayed text in JComboBox
>>  - Merge
>>  - Explicit frame dispose remove
>>  - merge
>>  - Review comment update
>>  - ... and 1 more: https://git.openjdk.org/jdk/compare/7ec22be6...1a48076b
>
> Looks good now.

@azuev-java As suggested by @aivanov-jdk  the current fix ensures that screen magnifier works well with the default renderer as well as custom renderer. Ci jobs are green with this fix.

Can you please re-review this PR?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14497#issuecomment-1806204005


More information about the client-libs-dev mailing list