RFR: 8224261: JProgressBar always with border painted around it

Abhishek Kumar abhiscxk at openjdk.org
Tue Nov 14 07:09:27 UTC 2023


On Fri, 10 Nov 2023 21:10:21 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> JProgressBar is always painted with border irrespective of the value set via the API `setBorderPainted(boolean value)` in Synth (Nimbus and GTK) LAF. Proposed fix is to add a check before painting the component.
>> 
>> CI jobs are green after the fix. Links attached to JBS.
>
> test/jdk/javax/swing/JProgressBar/TestProgressBarBorder.java line 79:
> 
>> 77: 
>> 78:                 BufferedImage borderPaintedImg =
>> 79:                         robot.createScreenCapture(new Rectangle(pt.x, pt.y,
> 
> I think the test can be simplified by rendering the progress bar into the buffered image directly.

I couldn't understand. Can you please explain a bit more?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16467#discussion_r1392081231


More information about the client-libs-dev mailing list