RFR: 8319103: Popups that request focus are not shown on Linux with Wayland [v3]

Phil Race prr at openjdk.org
Wed Nov 15 19:14:34 UTC 2023


On Tue, 14 Nov 2023 17:14:55 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> This is the fix for the regression introduced in [JDK-8280993](https://bugs.openjdk.org/browse/JDK-8280993).
>> 
>> That fix was to dismiss a popup if the owner loses the window focus when running in Wayland, and didn't take into account that the popup itself can be focusable.
>> 
>> This fix closes the popup only if the focus moves away from the calling window and the popup itself.
>> 
>> There is no jtreg test provided because it requires transferring the window focus to a non-X11 window, and our current robot implementation [does not allow this](https://bugs.openjdk.org/browse/JDK-8280983).
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Increase the number of columns to fit the text

Marked as reviewed by prr (Reviewer).

test/jdk/javax/swing/JPopupMenu/FocusablePopupDismissTest.java line 60:

> 58: 
> 59:             While the popup is displayed, click on a some system window.
> 60:             If the popup has disappeared, click Pass, otherwise click Fail.

"click on some other window on the desktop."

-------------

PR Review: https://git.openjdk.org/jdk/pull/16636#pullrequestreview-1732724827
PR Review Comment: https://git.openjdk.org/jdk/pull/16636#discussion_r1394651526


More information about the client-libs-dev mailing list