RFR: 5108458: JTable does not properly layout its content [v2]
Damon Nguyen
dnguyen at openjdk.org
Wed Nov 15 19:19:42 UTC 2023
On Tue, 7 Nov 2023 04:11:22 GMT, Tejesh R <tr at openjdk.org> wrote:
>> test/jdk/javax/swing/JTable/JTableRightAlignmentTest.java line 121:
>>
>>> 119: private static void saveImage(BufferedImage image, String fileName) {
>>> 120: try {
>>> 121: ImageIO.write(image, "png", new File(fileName));
>>
>> Is it OK to save an image here? In the past, I stored my images similar to in #7310 to store the image in the correct area for temporary images for a test.
>
> U mean to create a test directory and store image there?
Not a new test directory. In that referenced PR, I had to get the path to the directory where test files are stored temporarily. This helps with testing mainly.
`Path.of(System.getProperty("test.classes", "."));` was the path I used in the PR. I saved it to a var and wrote the image to that var followed by the image name.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16374#discussion_r1394670882
More information about the client-libs-dev
mailing list