RFR: 8318364: Add an FFM-based implementation of harfbuzz OpenType layout [v4]

Sergey Bylokhov serb at openjdk.org
Thu Nov 16 01:57:37 UTC 2023


On Tue, 7 Nov 2023 00:37:47 GMT, Phil Race <prr at openjdk.org> wrote:

> > > So we have somewhere around a fixed 125ms startup cost for the FFM case - as measured on my Mac,
> > > but only 35-40ms of that is attributable to the specific needs of layout.
> > 
> > 
> > That looks unfortunate. I guess if we will start to use ffm in other places we can easily spend of 1 second budget on startup=(
> 
> Yes, this case is sufficiently uncommon, that it is OK, and is a decent way to help us track improvements to FFM. But it would be another matter to have to do it for however many of our core software loops and AWT window manager interaction calls we need to get running for a minimal app.
> 
> > > layoutCnt=16000 total=193ms <<< app fully displayed
> > > vs
> > > layoutCnt=16000 total=453ms <<< app fully displayed
> > 
> > 
> > It looks strange that 16000 calls are not enough to warmup, and the difference is so large.
> 
> I am not a C2 expert, (not even an amateur), I just assume that it takes a lot of calls to be fully optimized.

@JornVernee this looks suspicious and seems unrelated to the cold startup issues we discussed before.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15476#issuecomment-1813640596


More information about the client-libs-dev mailing list