RFR: 8318113: CSS.BackgroundImage doesn't implement equals [v3]
Andrey Turbanov
aturbanov at openjdk.org
Thu Nov 16 10:22:36 UTC 2023
On Thu, 16 Nov 2023 07:04:43 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> CSSBackgroundImage.equals() is implemented
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>
> Use Objects.hashCode and add bugid
Use Objects.hashCode without explicit null check.
src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 2971:
> 2969: @Override
> 2970: public int hashCode() {
> 2971: return (this.svalue != null) ? Objects.hashCode(this.svalue) : 0;
Simplify:
Suggestion:
return Objects.hashCode(this.svalue);
-------------
Changes requested by aturbanov (Committer).
PR Review: https://git.openjdk.org/jdk/pull/16613#pullrequestreview-1734018859
PR Review Comment: https://git.openjdk.org/jdk/pull/16613#discussion_r1395472638
More information about the client-libs-dev
mailing list