RFR: 8315701: [macos] Regression: KeyEvent has different keycode on different keyboard layouts

Alexey Ivanov aivanov at openjdk.org
Thu Nov 16 18:27:35 UTC 2023


On Tue, 14 Nov 2023 21:22:37 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Updated previous fix (8262945) to work on extendedKeyCodes. Updated AcceleratorTest to use PassFailJFrame instead of Applet

I can't still make the test pass on macOS Ventura (13.5.2), yet the fix did improve the situation. Previously, fewer keystrokes led to *Fired* being printed.

The cases 2 and 5 do not work for me. I use a PC layout for Russian on Mac, period in this Russian layout is on "/?" key but pressing Ctrl+(/?) doesn't fires the event. Nor is the event fired when I press Alt+Ю (key with ".>").

The fix has resolved the issue with Ctrl+N: it works with the fix but doesn't without it.

test/jdk/java/awt/event/KeyEvent/AcceleratorTest/AcceleratorTest.java line 1:

> 1: /*

Is it possible to print which particular event fired? It could be useful for debugging.

I'd create a list of `Action`s with the names and shortcuts (as a KeyStroke and as string for printing) and then print each action name with corresponding shortcut. Or create a list of objects with corresponding data. I didn't think it through.

-------------

PR Review: https://git.openjdk.org/jdk/pull/16664#pullrequestreview-1735155100
PR Review Comment: https://git.openjdk.org/jdk/pull/16664#discussion_r1396161438


More information about the client-libs-dev mailing list