RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v26]
Julian Waters
jwaters at openjdk.org
Fri Nov 17 07:59:47 UTC 2023
On Thu, 16 Nov 2023 03:44:53 GMT, Phil Race <prr at openjdk.org> wrote:
> > I happened to ask around on the build-dev mailing lists about whether we include msvcp.dll with the JDK, here is Erik's response:
>
> Yes, I saw that. It doesn't make any difference. Although BTW the comment points out we shouldn't be doing static linking anymore.
>
> > This may be unrelated, but I really think we should kill the std::bad_alloc hack in awt.dll as such
>
> seems unrelated, yes, but I'd have to look at that, to see if there's a reason to touch it. Itchy fingers are not a valid reason.
I've converted awt_Canvas.cpp to use manual cleaup, as requested. Are we sure we really want to do this for the rest of the places where goto is an issue and not rely on the C++ Library? There are multiple usages of JNI_CHECK_PEER_GOTO in those areas, and manually expanding the macro in those areas will quickly become very messy
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-1815895692
More information about the client-libs-dev
mailing list