RFR: 5108458: JTable does not properly layout its content [v5]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Mon Nov 20 10:59:33 UTC 2023
On Mon, 20 Nov 2023 10:41:15 GMT, Tejesh R <tr at openjdk.org> wrote:
>> getCellRect spec says
>> `Returns a rectangle for the cell that lies at the intersection of row and column`
>>
>> What's the x position offset we are talking here?
>
> For RTL orientation [`getCellRect`](https://github.com/openjdk/jdk/blob/6c5e15c1a291ca5ba1e4c3a90351bc71665ce988/src/java.desktop/share/classes/javax/swing/JTable.java#L2977) returns position excluding the Offset meaning the gap between panel x till x position of table which is x position of first column. So instead of modifying at JTable class, I am updating here.
but we dont seem to have any issue with LTR rendering, so why this getXPosition is needed for LTR too?
Also, wouldn't existing `getRowMargin` have helped?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16374#discussion_r1399024012
More information about the client-libs-dev
mailing list