RFR: 6510914: JScrollBar.getMinimumSize() breaks the contract of JComponent.setMinimumSize() [v7]

Prasanta Sadhukhan psadhukhan at openjdk.org
Tue Nov 21 03:33:21 UTC 2023


> javadoc contract for JComponent.setMinimumSize(Dimension) states:
> 
> "Sets the minimum size of this component to a constant value. Subsequent calls to getMinimumSize will always return this value..."
> 
> However, JScrollBar overrides getMinimumSize() and breaks this contract - it always returns a minimum size derived from the preferred size even if you have previously called setMinimumSize()
> 
> Fix is made to check if mnimumSize is set and if so, honour it..

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Override set*Methods and update spec

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15325/files
  - new: https://git.openjdk.org/jdk/pull/15325/files/2733ea66..89aae1e2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15325&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15325&range=05-06

  Stats: 50 lines in 1 file changed: 49 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/15325.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15325/head:pull/15325

PR: https://git.openjdk.org/jdk/pull/15325


More information about the client-libs-dev mailing list