RFR: 5108458: JTable does not properly layout its content [v5]

Tejesh R tr at openjdk.org
Tue Nov 21 04:05:06 UTC 2023


On Tue, 21 Nov 2023 03:44:17 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> LTR rendering will work unless the Table is fully occupied w.r.t the Panel. Here the Max width of each column is set which is less than the Panel size where extra space would be there on left side of the Table. LTR doesn't need getXPosition because it'll always be 0/attached to Panel at left position. In JTableHeader [r.x](https://github.com/openjdk/jdk/blob/6c5e15c1a291ca5ba1e4c3a90351bc71665ce988/src/java.desktop/share/classes/javax/swing/table/JTableHeader.java#L399) is computed on this offset basis.
>
>> LTR doesn't need getXPosition
> 
> But it is called in `if (table.getComponentOrientation().isLeftToRight()) `condition above

Yes, actually it is not required because it gives/should give the same x position value. Have to remove it, might have added for checking if it had any effect on LTR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16374#discussion_r1400002281


More information about the client-libs-dev mailing list