RFR: 8225220: When the Tab Policy is checked,the scroll button direction displayed incorrectly.

Abhishek Kumar abhiscxk at openjdk.org
Tue Nov 21 18:15:24 UTC 2023


On Tue, 14 Nov 2023 04:22:57 GMT, Tejesh R <tr at openjdk.org> wrote:

>> JTabbedPane scroll button direction was incorrect because the widget type returned while painting the arrow was `SPINNER_ARROW_BUTTON`. Added the condition check for JTabbedPane before returning the widget type and based on the tab placement set by user, appropriate widget type is returned.
>> 
>> Tested the CI jobs against the fix and it was green. Link attached in JBS.
>
> test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneArrowDirection.java line 75:
> 
>> 73:             SwingUtilities.invokeAndWait(() -> {
>> 74:                 if (frame != null) {
>> 75:                     frame.dispose();
> 
> Dispose is not required here, since you are adding it to passFailJFrame.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16601#discussion_r1392012330


More information about the client-libs-dev mailing list