RFR: 8320443: [macos] Test java/awt/print/PrinterJob/PrinterDevice.java fails on macOS

Phil Race prr at openjdk.org
Tue Nov 21 21:29:21 UTC 2023


On Tue, 21 Nov 2023 21:23:12 GMT, Phil Race <prr at openjdk.org> wrote:

> For as long as we've had the macOS port, it seems that queries on the GraphicsConfiguration associated with
> a printer would give you null for the defaultTransform.
> Clearly this API isn't a popular one to call in such a context else we'd have had lots of reports.
> We have a test that would have caught it except that until recently the macOS printing implementation
> was swallowing exceptions it should not.

src/java.desktop/share/classes/sun/print/PSPrinterJob.java line 266:

> 264:    private AffineTransform mLastTransform;
> 265: 
> 266:    private double xres = PS_XRES;

This change has absolutely nothing to with the bug, but I just happened to notice it as I was bumbling around the various sources.
Its a pure clean up since both are "300", and it just seemed to me it wasn't worth the overhead of a bug of its own so I include it here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16773#discussion_r1401217473


More information about the client-libs-dev mailing list