RFR: 5108458: JTable does not properly layout its content [v6]

[Tejesh R]

On Tue, 21 Nov 2023 15:33:04 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review fix
>
> test/jdk/javax/swing/JTable/JTableRightAlignmentTest.java line 98:
> 
>> 96:                                     table.table.getLocationOnScreen().y,
>> 97:                                     table.table.getWidth() - allColumnWidths,
>> 98:                                     table.table.getHeight()));
> 
> This is the reason why I dislike the model design: `table.table` doesn't look good and is somewhat confusing. Moreover, `CustomTable` is not really _a table_ which makes the design even more confusing: a table contains a table.
> 
> I understand over-engineering a test is a waste of time, yet it feels too wrong this way. A clean test code will ease the work of another engineer who will need to deal with updating the test if anything changes.

Will work on it then.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16374#discussion_r1401608795