RFR: 5108458: JTable does not properly layout its content [v8]
Tejesh R
tr at openjdk.org
Wed Nov 29 13:40:16 UTC 2023
On Wed, 29 Nov 2023 09:10:56 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review fix
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTableUI.java line 2033:
>
>> 2031: for (int row = rMin; row <= rMax; row++) {
>> 2032: y += table.getRowHeight(row);
>> 2033: SwingUtilities2.drawHLine(g, damagedArea.x, damagedArea.x + tableWidth - 1, y - 1);
>
> Is this needed? seems like it's working even without this change..
Yeah, I think so, now since we have modified `JTable.getCellRect`, x position should be handled there. let me remove it and test....
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16374#discussion_r1409295322
More information about the client-libs-dev
mailing list