RFR: 5108458: JTable does not properly layout its content [v8]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Nov 30 04:14:10 UTC 2023


On Wed, 29 Nov 2023 13:18:28 GMT, Tejesh R <tr at openjdk.org> wrote:

>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTableUI.java line 582:
>> 
>>> 580:         TableColumn aColumn;
>>> 581:         int columnWidth;
>>> 582:         boolean ltrFlag = table.getComponentOrientation().isLeftToRight();
>> 
>> Is SynthTableUI change needed? Seems like your test is passing for Nimbus L&F even without this file change
>
> It is required in synth, it will fail without the fix. And I hope it applies for GTK also.

Synth provides the base and has no specific use, it is extended and used by Nimbus and GTK L&F..
It passes for me in Nimbus L&F in Windows without Synth**UI change for your testcase and JBS testcase as well..
If it fails in GTK without Synth*UI change, I guess we need to find out why it passing for Nimbus without the change and make necessary change in GTK specifically and not in common class.....
and even if it's needed in Synth, since the code seems to be same, the `paintCells` should call a common method from both Basic and Synth so that if a bug is found it can be fixed at one place

![image](https://github.com/openjdk/jdk/assets/43534309/144769c1-80c7-4df9-87e9-92269467118f)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16374#discussion_r1410132140


More information about the client-libs-dev mailing list