RFR: 5108458: JTable does not properly layout its content [v10]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Nov 30 09:15:23 UTC 2023


On Thu, 30 Nov 2023 08:08:33 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Table contents does not follow right-left Orientation when Max width of columns are set. This is due to not considering the offset in `x position` while painting table grid and table cell. The fix handles the offset and adjust the x position for each paint, similar to how header is painted. The fix is applied to both Basic and Synth Look and Feel. 
>> The fix is verified for all Look and Feel manually and test verifies on Metal L&F since automatic test cannot be generalized throughout other Look and Feel. 
>> CI tested is green for regression check and test check.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review fix

src/java.desktop/share/classes/javax/swing/JTable.java line 3013:

> 3011:             }
> 3012:             if( !getComponentOrientation().isLeftToRight() ) {
> 3013:                 r.x = getWidthInRightToLeft() - r.x - cm.getColumn(column).getWidth();

It will be good to add comments explaining why you are doing what you are doing for future recall and
more is less here...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16374#discussion_r1410372463


More information about the client-libs-dev mailing list