RFR: 8320608: Many jtreg printing tests are missing the @printer keyword [v2]

[Alexey Ivanov]

On Mon, 27 Nov 2023 18:48:52 GMT, Phil Race <prr at openjdk.org> wrote:

>> I see `SetOrient.java` has its sibling `SetOrient.html` where you added `@key printer`.
>> 
>> Since both files contain all the tags except for `@test` in the .java file, you should not remove the `@run` tag from the .java file and add `@key printer` to it.
>
> "Should not" is strong. Why ? There's no requirement do to this even though you can.
> https://openjdk.org/jtreg/faq.html#can-i-use-the-author-run-etc.-tags-in-other-files

That's the reason why I prefer you keep the `@run` tag in `SetOrient.java`: to document that it's *an applet test* — with the html file being the test starter.

> I saw that, and it didn't fail at all on mac for any case.  
> Not sure how much I want to get dragged into fixing the test, and there's no bug id to refer back to.

I'd like to make the test useful and ensure it tests the conditions it was written for. This is why I submitted a separate bug for fixing the test — it's out of scope for the current PR.

The test was written for [JDK-4250681](https://bugs.openjdk.org/browse/JDK-4250681): PrinterJob.print() generates IllegalArgumentException,NegativeArraySizeException.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16785#discussion_r1410861731
PR Review Comment: https://git.openjdk.org/jdk/pull/16785#discussion_r1410962571