RFR: 5108458: JTable does not properly layout its content [v12]

[Alexey Ivanov]

On Thu, 30 Nov 2023 17:20:40 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Table contents does not follow right-left Orientation when Max width of columns are set. This is due to not considering the offset in `x position` while painting table grid and table cell. The fix handles the offset and adjust the x position for each paint, similar to how header is painted. The fix is applied to both Basic and Synth Look and Feel. 
>> The fix is verified for all Look and Feel manually and test verifies on Metal L&F since automatic test cannot be generalized throughout other Look and Feel. 
>> CI tested is green for regression check and test check.
>
> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review fix

Changes requested by aivanov (Reviewer).

src/java.desktop/share/classes/javax/swing/JTable.java line 3014:

> 3012:             //Table columns are laid out from right to left when component
> 3013:             //orientation is set to ComponentOrientation.RIGHT_TO_LEFT,
> 3014:             //adjust the x coordinate for this case.

Suggestion:

            // Table columns are laid out from right to left when component
            // orientation is set to ComponentOrientation.RIGHT_TO_LEFT,
            // adjust the x coordinate for this case.

There's usually a space, it improves readability, just search for `//` in `JTable.java`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/16374#pullrequestreview-1758119254
PR Review Comment: https://git.openjdk.org/jdk/pull/16374#discussion_r1411063743