RFR: 8316146: Open some swing tests 4 [v7]
Harshitha Onkar
honkar at openjdk.org
Mon Oct 2 23:04:40 UTC 2023
On Mon, 2 Oct 2023 22:21:23 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> test/jdk/javax/swing/ToolTipManager/bug5078214.java line 30:
>>
>>> 28: * @library ../regtesthelpers /test/lib
>>> 29: * @build JRobot
>>> 30: * @build jtreg.SkippedException
>>
>> Suggestion:
>>
>> * @library /test/lib
>> * @build jtreg.SkippedException
>>
>> JRobot is not required for this test, it can be replaced with normal Robot calls and jtreg header can be modified as above.
>
> As per convention it is better to place the `@key headful` at the start after `@test or @bug`.
@alisenchung You missed removing `../regtesthelpers` from @library tag :)
Also please move the @key tag as suggested above.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15875#discussion_r1343241226
More information about the client-libs-dev
mailing list