RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v2]
Damon Nguyen
dnguyen at openjdk.org
Mon Oct 2 23:51:05 UTC 2023
On Mon, 2 Oct 2023 23:33:44 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove pack for explicit size
>
> test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 84:
>
>> 82: DnDConstants.ACTION_COPY, dgl);
>> 83: frame.setPreferredSize(new Dimension(200, 200));
>> 84: frame.pack();
>
> Suggestion:
>
> frame.setSize(200, 200);
>
> frame.pack() not required as frame size is explicitly specified.
Good call. Was testing out different changes, and this was leftover. Modified back to setSize. Thanks
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16018#discussion_r1343262209
More information about the client-libs-dev
mailing list