RFR: 8316146: Open some swing tests 4 [v9]

Harshitha Onkar honkar at openjdk.org
Tue Oct 3 16:37:51 UTC 2023


On Tue, 3 Oct 2023 13:47:23 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed jtreg header
>
> test/jdk/javax/swing/ToolTipManager/bug5078214.java line 31:
> 
>> 29:  * @build jtreg.SkippedException
>> 30:  * @run main bug5078214
>> 31:  */
> 
> The test does not compile:
> 
> runner starting test: javax/swing/ToolTipManager/bug5078214.java
> runner finished test: javax/swing/ToolTipManager/bug5078214.java
> Error. can't find jtreg.SkippedException in test directory or libraries
> Test results: error: 1
> 
> 
> You still use **`/test/lib`** for `jtreg.SkippedException`.

@alisenchung 
Previously what I meant is remove only `../regtesthelpers` and retain `/test/lib` in @library tag. Your jtreg header should look something like below.


/*
 * @test
 * @bug 5078214
 * @key headful
 * @summary ToolTip is shown partially when the application is near the bottom of screen.
 * @library /test/lib
 * @build jtreg.SkippedException
 * @run main bug5078214
 */

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15875#discussion_r1344412829


More information about the client-libs-dev mailing list