RFR: 8315986: javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location [v2]

Alexey Ivanov aivanov at openjdk.org
Tue Oct 3 20:40:47 UTC 2023


On Fri, 29 Sep 2023 05:05:07 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Test was run without waiting for UI to be made visible leading to IllegalComponentStateException.
>> Used robot.delay consistent with other headful tests to made the test wait after UI is created and shown.
>> 
>> Test passed in several iterations in all platforms. Link in JBS
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add setAutoWaitForIdle

Marked as reviewed by aivanov (Reviewer).

test/jdk/javax/swing/JMenuItem/4654927/bug4654927.java line 56:

> 54:             String systemLAF = UIManager.getSystemLookAndFeelClassName();
> 55:             // the test is not applicable to Motif L&F
> 56:             if (systemLAF.endsWith("MotifLookAndFeel")){

Suggestion:

            if (systemLAF.endsWith("MotifLookAndFeel")) {

-------------

PR Review: https://git.openjdk.org/jdk/pull/15677#pullrequestreview-1656078503
PR Review Comment: https://git.openjdk.org/jdk/pull/15677#discussion_r1344704658


More information about the client-libs-dev mailing list