RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v3]

Damon Nguyen dnguyen at openjdk.org
Wed Oct 4 17:35:10 UTC 2023


On Wed, 4 Oct 2023 11:38:01 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Sure can do. Is this to replace the initial `waitForIdle` after robot's creation? So, remove the `waitForIdle` and add `latch.await()` before robot's creation?
>
> I'm not sure it's the right idea. If a paint occurred, it means the frame should be displayed on the screen. Yet it does not account for window animations. Perhaps, it does not make sense to introduce more complications which could be not as reliable.

Sure, I agree with this. I'll leave latch & the overridden paint out for now then.

>> I reduced the `DELAY_TIME` to 500. Thanks for the suggestion. I got used to setting the default delay times to 1000 for these types of tests, and am trying to break the habit and reduce delays further to 500 where possible.
>
> Well, I meant that you could reduce the delay if you add the latch.
> 
> However, 500ms should be enough now. Windows Vista and Windows 7 had long window animations when a window was shown on the screen, I believe this is where the delay of 1 second comes from. Windows 10 and 11 still have this animation but it's quicker.

Gotcha, I'll leave it as is then. Thanks

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16018#discussion_r1346233339
PR Review Comment: https://git.openjdk.org/jdk/pull/16018#discussion_r1346233648


More information about the client-libs-dev mailing list