RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v4]

Damon Nguyen dnguyen at openjdk.org
Wed Oct 4 17:45:30 UTC 2023


On Wed, 4 Oct 2023 11:34:13 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unnecessary delay. Modify delay amount. Add break.
>
> test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 107:
> 
>> 105:                     System.err.println("Incorrect action during loop");
>> 106:                     break;
>> 107:                 }
> 
> Actually, I meant adding it as part of the condition in the for-loop itself. However, it works either way.
> 
> The initial bug report for [JDK-4774532](https://bugs.openjdk.org/browse/JDK-4774532) says `dragOver` shouldn't be called at all. Do we want to update the test for a stricter assertion. For me, `dragOver` is never called.

It does look cleaner as a part of the for-loop itself, so I moved it in. For updating the test with a stricter assertion, maybe it's better to leave this as is for now since it doesn't necessarily hurt the test from what I can tell.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16018#discussion_r1346241701


More information about the client-libs-dev mailing list