RFR: 8315484: java/awt/dnd/RejectDragDropActionTest.java timed out [v3]

Damon Nguyen dnguyen at openjdk.org
Thu Oct 5 17:45:58 UTC 2023


On Thu, 5 Oct 2023 16:03:18 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> I can't seem to tell whether or not the JVM exits at the end of the test when the frame is disposed. Does removing the listeners work for you? And where are you checking the stack trace? I can't reproduce this on my machine
>
>> I can't reproduce this on my machine
> 
> Me neither.
> 
>> Does removing the listeners work for you?
> 
> I haven't run the test in the CI with listeners removed; I haven't tested it in any way at all. I'm just looking for explanation why the JVM doesn't exit.
> 
>> And where are you checking the stack trace?
> 
> I checked the CI logs. I'll explain privately.

I tried running the test at nearly its original state (I only added the `setSize` and `setLocationRelativeTo`) and got a failure. Looking at the stack, its the same as you mentioned. I tried re-running the test with the removal of the mouseListeners as suggested, and for the first 100 repeats, it passes. But, I ran another 100 and got a failure. Looking at the stack again, it looks identical to the failure before. Looking at the test, I'm not too sure what can be causing this. The only things that seem suspicious are the drag listeners as you mentioned.

However, since the accumulation of the changes doesn't seem to cause any failures anymore, should I just follow through with this PR? I can raise another bug if needed for this intermittent failure. Can't identify what's causing this though..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16018#discussion_r1347777824


More information about the client-libs-dev mailing list