RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v13]

Renjith Kannath Pariyangad duke at openjdk.org
Fri Oct 6 11:17:01 UTC 2023


> Hi Reviewers,
> 
> Observations :
> 1. Without com initialize if we access Mixer for recording, library loaded invalid GUID and clipped description in windows(ID not found in registry). With com initialization library load proper GUID (same as registry).
> 2. For Play back device always loading proper device GUID irrespective of com Initialization.
> 
> Test:
> Since screen lock and unlock workflow required for reproducing this issue, did coupe of iteration of manual testing post fix and confirmed its resolving the problem.
> To reconfirm nothing is broken, executed all audio related test cases on test bench post fix and all are green.
> 
> Please review the changes and let me know your comments if any.
> 
> Regards,
> Renjith.

Renjith Kannath Pariyangad has updated the pull request incrementally with three additional commits since the last revision:

 - Whitespace error fixed
 - Whitespace error fixed
 - CoInitializeEx error check modified with better condition

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14898/files
  - new: https://git.openjdk.org/jdk/pull/14898/files/c4512410..0502dc94

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14898&range=12
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14898&range=11-12

  Stats: 25 lines in 2 files changed: 21 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/14898.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14898/head:pull/14898

PR: https://git.openjdk.org/jdk/pull/14898


More information about the client-libs-dev mailing list