RFR: 8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly [v2]

Harshitha Onkar honkar at openjdk.org
Fri Oct 6 17:05:08 UTC 2023


On Wed, 4 Oct 2023 17:00:42 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8316947: Review comments solved
>
> test/jdk/java/awt/event/MouseEvent/MouseEnterExitTest.java line 66:
> 
>> 64:         public void mouseEntered(MouseEvent e) {
>> 65:             System.out
>> 66:                 .println("MouseEntered " + e.getSource().getClass().getName());
> 
> It is a bit odd to have a line break after sys.out. It looks better this way.
> 
> 
>  System.out.println("MouseEntered "
>                     + e.getSource().getClass().getName());

I would add the line break after "MouseEntered/Exited" as above, looks cleaner and preserves line length.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15961#discussion_r1348985296


More information about the client-libs-dev mailing list