RFR: JDK-8294090 : Aligns the CSS <rgb()> and <rgba()> function behaviours [v3]
Phil Race
prr at openjdk.org
Sat Oct 7 23:49:03 UTC 2023
On Sun, 20 Aug 2023 23:07:01 GMT, ScientificWare <duke at openjdk.org> wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8294090 : Aligns the CSS `<rgb()>` and `<rgba()>` function behaviours](https://bugs.java.com/bugdatabase/view_bug?bug_id=8294090)
>>
>> This is tracked in JBS as
>> - [JDK-8294090 : Aligns the CSS `<rgb()>` and `<rgba()>` function behaviours](https://bugs.openjdk.java.net/browse/JDK-8294090)
>>
>> Aligns the `<rgb()>` and `<rgba()>` function behaviours in CSS.java, as described in :
>> CSS Color Module Level 4
>> W3C Candidate Recommendation Snapshot, 5 July 2022
>> [4.1 The `<Color>` syntax](https://www.w3.org/TR/css-color-4/#color-syntax)
>> [6.1. The RGB functions: rgb() and rgba()](https://www.w3.org/TR/css-color-4/#funcdef-rgb)
>>
>> Designed from : [ScientificWare JDK-8294090 : Aligns the CSS <rgb()> and <rgba()> function behaviours](https://github.com/scientificware/jdk/issues/16)
>
> ScientificWare has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
>
> - Merge branch 'scientificware-patch-004-CSS-aligns_rgb_and_rgba_function_behaviours' of github.com:scientificware/jdk into scientificware-patch-004-CSS-aligns_rgb_and_rgba_function_behaviours
> - Merge branch 'openjdk:master' into scientificware-patch-004-CSS-aligns_rgb_and_rgba_function_behaviours
> - Merge master
> - RGBandRGBAalignmentBehaviours.java :
> - Change list name.
> - CSS.java :
> - Adds a comment about consecutive non space separators.
> - Adds e uppercase test.
>
> RGBandRGBAalignmentBehaviours.java :
> - Adds test cases with uppercase e.
> - Merge master
> - 8294090 : Corrects RGBandRGBAalignmentBehaviours.java file permission.
> - 8294090 :
>
> CSS.java :
> - Adds links to CSS-COLOR-4 and CSS-VALUE-4 specifications.
> - Update PARSE RGB method comments.
> - Adds base-ten exponent support.
>
> RGBandRGBAalignmentBehaviours.java :
> - Adds a set of tests for RGB functions.
> - Merge master
>
> # Conflicts:
> # src/java.desktop/share/classes/javax/swing/text/html/CSS.java
> - Amélioration de la prise en charge des fonctions rgb et rgba concernant les couleurs.
Changes requested by prr (Reviewer).
Read the comment in https://github.com/openjdk/jdk/pull/9825.
This PR needs to be merged into that PR and this PR withdrawn.
Bugs should be closed as dups.
I don't intend to do a detailed review of this PR until the content is merged into the other one.
src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 1458:
> 1456: * </a> specifications.
> 1457: * By example <code>rgb(rc gc bc)</code>,
> 1458: * <code>rgb(rc,gc,bc)</code>, <code>rgb(rc gc bc / ac)</code>,
For many years javadoc has preferred {@code rgb(rc,gc,bc)} instead of <code> .... </code>
Since this comment is being updated existing and new cases should be converted.
-------------
PR Review: https://git.openjdk.org/jdk/pull/15262#pullrequestreview-1636391087
PR Comment: https://git.openjdk.org/jdk/pull/15262#issuecomment-1751866720
PR Comment: https://git.openjdk.org/jdk/pull/15262#issuecomment-1751867052
PR Review Comment: https://git.openjdk.org/jdk/pull/15262#discussion_r1332107583
More information about the client-libs-dev
mailing list