RFR: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library [v13]
Renjith Kannath Pariyangad
duke at openjdk.org
Mon Oct 9 03:20:20 UTC 2023
On Fri, 6 Oct 2023 15:55:54 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - Whitespace error fixed
>> - Whitespace error fixed
>> - CoInitializeEx error check modified with better condition
>
> src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp line 234:
>
>> 232: }
>> 233:
>> 234: if(hr != RPC_E_CHANGED_MODE) {
>
> Suggestion:
>
> if (hr != RPC_E_CHANGED_MODE) {
>
> Space between the `if` keyword and the opening parenthesis.
Included all suggestions
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14898#discussion_r1349834270
More information about the client-libs-dev
mailing list